001/////////////////////////////////////////////////////////////////////////////////////////////// 002// checkstyle: Checks Java source code and other text files for adherence to a set of rules. 003// Copyright (C) 2001-2026 the original author or authors. 004// 005// This library is free software; you can redistribute it and/or 006// modify it under the terms of the GNU Lesser General Public 007// License as published by the Free Software Foundation; either 008// version 2.1 of the License, or (at your option) any later version. 009// 010// This library is distributed in the hope that it will be useful, 011// but WITHOUT ANY WARRANTY; without even the implied warranty of 012// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU 013// Lesser General Public License for more details. 014// 015// You should have received a copy of the GNU Lesser General Public 016// License along with this library; if not, write to the Free Software 017// Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA 018/////////////////////////////////////////////////////////////////////////////////////////////// 019 020package com.puppycrawl.tools.checkstyle.checks; 021 022import java.util.Arrays; 023import java.util.regex.Pattern; 024 025import com.puppycrawl.tools.checkstyle.StatelessCheck; 026import com.puppycrawl.tools.checkstyle.api.AbstractCheck; 027import com.puppycrawl.tools.checkstyle.api.DetailAST; 028import com.puppycrawl.tools.checkstyle.api.TokenTypes; 029import com.puppycrawl.tools.checkstyle.utils.CommonUtil; 030import com.puppycrawl.tools.checkstyle.utils.TokenUtil; 031 032/** 033 * <div> 034 * The check to ensure that lines with code do not end with comment. 035 * For the case of {@code //} comments that means that the only thing that should precede 036 * it is whitespace. It doesn't check comments if they do not end a line; for example, 037 * it accepts the following: {@code Thread.sleep( 10 /*some comment here* / );} 038 * Format property is intended to deal with the <code>} // while</code> example. 039 * </div> 040 * 041 * <p> 042 * Rationale: Steve McConnell in <cite>Code Complete</cite> suggests that endline 043 * comments are a bad practice. An end line comment would be one that is on 044 * the same line as actual code. For example: 045 * </p> 046 * {@snippet : 047 * a = b + c; // Some insightful comment 048 * d = e / f; /* Some insightful block comment * / 049 * } 050 * 051 * <p> 052 * Quoting <cite>Code Complete</cite> for the justification: 053 * </p> 054 * <ul> 055 * <li> 056 * "The comments have to be aligned so that they do not interfere with the visual 057 * structure of the code. If you don't align them neatly, they'll make your listing 058 * look like it's been through a washing machine." 059 * </li> 060 * <li> 061 * "Endline comments tend to be hard to format...It takes time to align them. 062 * Such time is not spent learning more about the code; it's dedicated solely 063 * to the tedious task of pressing the spacebar or tab key." 064 * </li> 065 * <li> 066 * "Endline comments are also hard to maintain. If the code on any line containing 067 * an endline comment grows, it bumps the comment farther out, and all the other 068 * endline comments will have to bumped out to match. Styles that are hard to 069 * maintain aren't maintained...." 070 * </li> 071 * <li> 072 * "Endline comments also tend to be cryptic. The right side of the line doesn't 073 * offer much room and the desire to keep the comment on one line means the comment 074 * must be short. Work then goes into making the line as short as possible instead 075 * of as clear as possible. The comment usually ends up as cryptic as possible...." 076 * </li> 077 * <li> 078 * "A systemic problem with endline comments is that it's hard to write a meaningful 079 * comment for one line of code. Most endline comments just repeat the line of code, 080 * which hurts more than it helps." 081 * </li> 082 * </ul> 083 * 084 * <p> 085 * McConnell's comments on being hard to maintain when the size of the line changes 086 * are even more important in the age of automated refactorings. 087 * </p> 088 * 089 * @since 3.4 090 */ 091@StatelessCheck 092public class TrailingCommentCheck extends AbstractCheck { 093 094 /** 095 * A key is pointing to the warning message text in "messages.properties" 096 * file. 097 */ 098 public static final String MSG_KEY = "trailing.comments"; 099 100 /** Specify pattern for strings to be formatted without comment specifiers. */ 101 private static final Pattern FORMAT_LINE = Pattern.compile("/"); 102 103 /** 104 * Define pattern for text allowed in trailing comments. 105 * This pattern will not be applied to multiline comments. 106 */ 107 private Pattern legalComment; 108 109 /** Specify pattern for strings allowed before the comment. */ 110 private Pattern format = Pattern.compile("^[\\s});]*$"); 111 112 /** 113 * Creates a new {@code TrailingCommentCheck} instance. 114 */ 115 public TrailingCommentCheck() { 116 // no code by default 117 } 118 119 /** 120 * Setter to define pattern for text allowed in trailing comments. 121 * This pattern will not be applied to multiline comments. 122 * 123 * @param legalComment pattern to set. 124 * @since 4.2 125 */ 126 public void setLegalComment(final Pattern legalComment) { 127 this.legalComment = legalComment; 128 } 129 130 /** 131 * Setter to specify pattern for strings allowed before the comment. 132 * 133 * @param pattern a pattern 134 * @since 3.4 135 */ 136 public final void setFormat(Pattern pattern) { 137 format = pattern; 138 } 139 140 @Override 141 public boolean isCommentNodesRequired() { 142 return true; 143 } 144 145 @Override 146 public int[] getDefaultTokens() { 147 return getRequiredTokens(); 148 } 149 150 @Override 151 public int[] getAcceptableTokens() { 152 return getRequiredTokens(); 153 } 154 155 @Override 156 public int[] getRequiredTokens() { 157 return new int[] { 158 TokenTypes.SINGLE_LINE_COMMENT, 159 TokenTypes.BLOCK_COMMENT_BEGIN, 160 }; 161 } 162 163 @Override 164 public void visitToken(DetailAST ast) { 165 if (ast.getType() == TokenTypes.SINGLE_LINE_COMMENT) { 166 checkSingleLineComment(ast); 167 } 168 else { 169 checkBlockComment(ast); 170 } 171 } 172 173 /** 174 * Checks if single-line comment is legal. 175 * 176 * @param ast Detail ast element to be checked. 177 */ 178 private void checkSingleLineComment(DetailAST ast) { 179 final int lineNo = ast.getLineNo(); 180 final String comment = ast.getFirstChild().getText(); 181 final int[] lineBeforeCodePoints = 182 Arrays.copyOfRange(getLineCodePoints(lineNo - 1), 0, ast.getColumnNo()); 183 final String lineBefore = new String(lineBeforeCodePoints, 0, lineBeforeCodePoints.length); 184 185 if (!format.matcher(lineBefore).find() && !isLegalCommentContent(comment)) { 186 log(ast, MSG_KEY); 187 } 188 } 189 190 /** 191 * Method to check if block comment is in correct format. 192 * 193 * @param ast Detail ast element to be checked. 194 */ 195 private void checkBlockComment(DetailAST ast) { 196 final int lineNo = ast.getLineNo(); 197 final DetailAST firstChild = ast.getFirstChild(); 198 final DetailAST lastChild = ast.getLastChild(); 199 final String comment = firstChild.getText(); 200 int[] lineCodePoints = getLineCodePoints(lineNo - 1); 201 202 if (lineCodePoints.length > lastChild.getColumnNo() + 1) { 203 lineCodePoints = Arrays.copyOfRange(lineCodePoints, 204 lastChild.getColumnNo() + 2, lineCodePoints.length); 205 } 206 207 String line = new String(lineCodePoints, 0, lineCodePoints.length); 208 line = FORMAT_LINE.matcher(line).replaceAll(""); 209 210 final int[] lineBeforeCodePoints = 211 Arrays.copyOfRange(getLineCodePoints(lineNo - 1), 0, ast.getColumnNo()); 212 final String lineBefore = new String(lineBeforeCodePoints, 0, lineBeforeCodePoints.length); 213 final boolean isCommentAtEndOfLine = ast.getLineNo() != lastChild.getLineNo() 214 || CommonUtil.isBlank(line); 215 final boolean isLegalBlockComment = isLegalCommentContent(comment) 216 && TokenUtil.areOnSameLine(firstChild, lastChild) 217 || format.matcher(lineBefore).find(); 218 219 if (isCommentAtEndOfLine && !isLegalBlockComment) { 220 log(ast, MSG_KEY); 221 } 222 } 223 224 /** 225 * Checks if given comment content is legal. 226 * 227 * @param commentContent comment content to check. 228 * @return true if the content is legal. 229 */ 230 private boolean isLegalCommentContent(String commentContent) { 231 return legalComment != null && legalComment.matcher(commentContent).find(); 232 } 233 234}