Class OneStatementPerLineCheck
java.lang.Object
com.puppycrawl.tools.checkstyle.AbstractAutomaticBean
com.puppycrawl.tools.checkstyle.api.AbstractViolationReporter
com.puppycrawl.tools.checkstyle.api.AbstractCheck
com.puppycrawl.tools.checkstyle.checks.coding.OneStatementPerLineCheck
- All Implemented Interfaces:
Configurable,Contextualizable
Checks that there is only one statement per line.
Rationale: It's very difficult to read multiple statements on one line.
In the Java programming language, statements are the fundamental unit of execution. All statements except blocks are terminated by a semicolon. Blocks are denoted by open and close curly braces.
OneStatementPerLineCheck checks the following types of statements: block statements, variable declaration statements, import statements, assignment statements, expression statements, increment statements, object creation statements, 'for loop' statements, 'break' statements, 'continue' statements, 'return' statements, resources statements (optional).
Notes: Unnecessary semicolons are ignored.
- Since:
- 5.3
-
Nested Class Summary
Nested classes/interfaces inherited from class com.puppycrawl.tools.checkstyle.AbstractAutomaticBean
AbstractAutomaticBean.OutputStreamOptions -
Field Summary
FieldsModifier and TypeFieldDescriptionprivate booleanThe first statement of lambda or anonymous class shouldn't be violation.private intHold the line-number where the last statement ended.private intHold the line number of the last statement in the current nesting scope.private intHold the line-number where the last resource variable statement ended.static final StringA key is pointing to the warning message text in "messages.properties" file.Stack of statement line-number for nested lambdas and anonymous classes.private booleanEnable resources processing.Set of valid semi parent. -
Constructor Summary
Constructors -
Method Summary
Modifier and TypeMethodDescriptionvoidCalled before the starting to process a tree.private voidChecks if statement of given semicolon is in different line than previous statement.private booleancheckResourceVariable(DetailAST currentStatement) Checks whether the current statement represents a valid resource declaration in a try-with-resources statement.int[]The configurable token set.int[]Returns the default token a check is interested in.private static DetailASTgetLastNestedLeafNode(DetailAST startToken) Finds the last nested leaf node.int[]The tokens that this check must be registered for.private static DetailASTgetStartNodeInExpression(DetailAST expression) Finds the leftmost leaf node in the given expression's subtree.private static DetailASTReturns the starting node of the statement, or the previous statement's start if the current one is an empty statement.private static booleanisResource(DetailAST ast) Checks that given node is a resource.private booleanisValidStatement(DetailAST statementStart) Checks whether the current statement is placed on a separate line from the previous statement.voidleaveToken(DetailAST ast) Called after all the child nodes have been process.private voidlogViolation(DetailAST violationNode) Logs a violation at the given AST node.voidsetTreatTryResourcesAsStatement(boolean treatTryResourcesAsStatement) Setter to enable resources processing.voidvisitToken(DetailAST ast) Called to process a token.Methods inherited from class com.puppycrawl.tools.checkstyle.api.AbstractCheck
clearViolations, destroy, finishTree, getFileContents, getFilePath, getLine, getLineCodePoints, getLines, getTabWidth, getTokenNames, getViolations, init, isCommentNodesRequired, log, log, log, setFileContents, setTabWidth, setTokensMethods inherited from class com.puppycrawl.tools.checkstyle.api.AbstractViolationReporter
finishLocalSetup, getCustomMessages, getId, getMessageBundle, getSeverity, getSeverityLevel, setId, setSeverityMethods inherited from class com.puppycrawl.tools.checkstyle.AbstractAutomaticBean
configure, contextualize, getConfiguration, setupChild
-
Field Details
-
MSG_KEY
A key is pointing to the warning message text in "messages.properties" file.- See Also:
-
VALID_SEMI_PARENT
Set of valid semi parent. -
nestingScope
Stack of statement line-number for nested lambdas and anonymous classes. Used to isolate validation to the current nesting depth. -
lastStatementEnd
Hold the line-number where the last statement ended. -
lastVariableResourceStatementEnd
Hold the line-number where the last resource variable statement ended. -
treatTryResourcesAsStatement
Enable resources processing. -
lastStatementInCurrentScope
Hold the line number of the last statement in the current nesting scope. -
isFirstStatementOfLambdaOrAnonymous
The first statement of lambda or anonymous class shouldn't be violation.
-
-
Constructor Details
-
OneStatementPerLineCheck
public OneStatementPerLineCheck()Creates a newOneStatementPerLineCheckinstance.
-
-
Method Details
-
setTreatTryResourcesAsStatement
Setter to enable resources processing.- Parameters:
treatTryResourcesAsStatement- user's value of treatTryResourcesAsStatement.- Since:
- 8.23
-
getDefaultTokens
Description copied from class:AbstractCheckReturns the default token a check is interested in. Only used if the configuration for a check does not define the tokens.- Specified by:
getDefaultTokensin classAbstractCheck- Returns:
- the default tokens
- See Also:
-
getAcceptableTokens
Description copied from class:AbstractCheckThe configurable token set. Used to protect Checks against malicious users who specify an unacceptable token set in the configuration file. The default implementation returns the check's default tokens.- Specified by:
getAcceptableTokensin classAbstractCheck- Returns:
- the token set this check is designed for.
- See Also:
-
getRequiredTokens
Description copied from class:AbstractCheckThe tokens that this check must be registered for.- Specified by:
getRequiredTokensin classAbstractCheck- Returns:
- the token set this must be registered for.
- See Also:
-
beginTree
Description copied from class:AbstractCheckCalled before the starting to process a tree. Ideal place to initialize information that is to be collected whilst processing a tree.- Overrides:
beginTreein classAbstractCheck- Parameters:
rootAST- the root of the tree
-
visitToken
Description copied from class:AbstractCheckCalled to process a token.- Overrides:
visitTokenin classAbstractCheck- Parameters:
ast- the token to process
-
leaveToken
Description copied from class:AbstractCheckCalled after all the child nodes have been process.- Overrides:
leaveTokenin classAbstractCheck- Parameters:
ast- the token leaving
-
checkIfSemicolonIsInDifferentLineThanPrevious
Checks if statement of given semicolon is in different line than previous statement.- Parameters:
ast- semicolon to check
-
logViolation
Logs a violation at the given AST node.- Parameters:
violationNode- token at which violation occurred.
-
isValidStatement
Checks whether the current statement is placed on a separate line from the previous statement.- Parameters:
statementStart- token representing the start of the current statement- Returns:
trueif the current statement starts on a different line than the previous statement;falseotherwise
-
getStatementStart
Returns the starting node of the statement, or the previous statement's start if the current one is an empty statement.- Parameters:
ast- the SEMI token.- Returns:
- the start of the associated statement or the previous sibling.
-
checkResourceVariable
Checks whether the current statement represents a valid resource declaration in a try-with-resources statement.- Parameters:
currentStatement- the statement to check- Returns:
trueif the statement is a valid resource declaration;falseotherwise.
-
getStartNodeInExpression
Finds the leftmost leaf node in the given expression's subtree.- Parameters:
expression- EXPR node.- Returns:
- the leftmost leaf
DetailASTnode
-
getLastNestedLeafNode
Finds the last nested leaf node.- Parameters:
startToken- start token of statement.- Returns:
- the last nested leaf
DetailASTnode
-
isResource
Checks that given node is a resource.- Parameters:
ast- semicolon to check- Returns:
- true if node is a resource
-