001///////////////////////////////////////////////////////////////////////////////////////////////
002// checkstyle: Checks Java source code and other text files for adherence to a set of rules.
003// Copyright (C) 2001-2025 the original author or authors.
004//
005// This library is free software; you can redistribute it and/or
006// modify it under the terms of the GNU Lesser General Public
007// License as published by the Free Software Foundation; either
008// version 2.1 of the License, or (at your option) any later version.
009//
010// This library is distributed in the hope that it will be useful,
011// but WITHOUT ANY WARRANTY; without even the implied warranty of
012// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
013// Lesser General Public License for more details.
014//
015// You should have received a copy of the GNU Lesser General Public
016// License along with this library; if not, write to the Free Software
017// Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
018///////////////////////////////////////////////////////////////////////////////////////////////
019
020package com.puppycrawl.tools.checkstyle.checks.imports;
021
022import java.util.HashSet;
023import java.util.Set;
024
025import com.puppycrawl.tools.checkstyle.StatelessCheck;
026import com.puppycrawl.tools.checkstyle.api.AbstractCheck;
027import com.puppycrawl.tools.checkstyle.api.DetailAST;
028import com.puppycrawl.tools.checkstyle.api.FullIdent;
029import com.puppycrawl.tools.checkstyle.api.TokenTypes;
030
031/**
032 * <div>
033 * Checks that there are no import statements that use the {@code *} notation.
034 * </div>
035 *
036 * <p>
037 * Rationale: Importing all classes from a package or static
038 * members from a class leads to tight coupling between packages
039 * or classes and might lead to problems when a new version of a
040 * library introduces name clashes.
041 * </p>
042 *
043 * <p>
044 * Notes:
045 * Note that property {@code excludes} is not recursive, subpackages of excluded
046 * packages are not automatically excluded.
047 * </p>
048 * <ul>
049 * <li>
050 * Property {@code allowClassImports} - Control whether to allow starred class
051 * imports like {@code import java.util.*;}.
052 * Type is {@code boolean}.
053 * Default value is {@code false}.
054 * </li>
055 * <li>
056 * Property {@code allowStaticMemberImports} - Control whether to allow starred
057 * static member imports like {@code import static org.junit.Assert.*;}.
058 * Type is {@code boolean}.
059 * Default value is {@code false}.
060 * </li>
061 * <li>
062 * Property {@code excludes} - Specify packages where starred class imports are
063 * allowed and classes where starred static member imports are allowed.
064 * Type is {@code java.lang.String[]}.
065 * Default value is {@code ""}.
066 * </li>
067 * </ul>
068 *
069 * <p>
070 * Parent is {@code com.puppycrawl.tools.checkstyle.TreeWalker}
071 * </p>
072 *
073 * <p>
074 * Violation Message Keys:
075 * </p>
076 * <ul>
077 * <li>
078 * {@code import.avoidStar}
079 * </li>
080 * </ul>
081 *
082 * @since 3.0
083 */
084@StatelessCheck
085public class AvoidStarImportCheck
086    extends AbstractCheck {
087
088    /**
089     * A key is pointing to the warning message text in "messages.properties"
090     * file.
091     */
092    public static final String MSG_KEY = "import.avoidStar";
093
094    /** Suffix for the star import. */
095    private static final String STAR_IMPORT_SUFFIX = ".*";
096
097    /**
098     * Specify packages where starred class imports are
099     * allowed and classes where starred static member imports are allowed.
100     */
101    private final Set<String> excludes = new HashSet<>();
102
103    /**
104     * Control whether to allow starred class imports like
105     * {@code import java.util.*;}.
106     */
107    private boolean allowClassImports;
108
109    /**
110     * Control whether to allow starred static member imports like
111     * {@code import static org.junit.Assert.*;}.
112     */
113    private boolean allowStaticMemberImports;
114
115    @Override
116    public int[] getDefaultTokens() {
117        return getRequiredTokens();
118    }
119
120    @Override
121    public int[] getAcceptableTokens() {
122        return getRequiredTokens();
123    }
124
125    @Override
126    public int[] getRequiredTokens() {
127        // original implementation checks both IMPORT and STATIC_IMPORT tokens to avoid ".*" imports
128        // however user can allow using "import" or "import static"
129        // by configuring allowClassImports and allowStaticMemberImports
130        // To avoid potential confusion when user specifies conflicting options on configuration
131        // (see example below) we are adding both tokens to Required list
132        //   <module name="AvoidStarImport">
133        //      <property name="tokens" value="IMPORT"/>
134        //      <property name="allowStaticMemberImports" value="false"/>
135        //   </module>
136        return new int[] {TokenTypes.IMPORT, TokenTypes.STATIC_IMPORT};
137    }
138
139    /**
140     * Setter to specify packages where starred class imports are
141     * allowed and classes where starred static member imports are allowed.
142     *
143     * @param excludesParam package names/fully-qualifies class names
144     *     where star imports are ok
145     * @since 3.2
146     */
147    public void setExcludes(String... excludesParam) {
148        for (final String exclude : excludesParam) {
149            if (exclude.endsWith(STAR_IMPORT_SUFFIX)) {
150                excludes.add(exclude);
151            }
152            else {
153                excludes.add(exclude + STAR_IMPORT_SUFFIX);
154            }
155        }
156    }
157
158    /**
159     * Setter to control whether to allow starred class imports like
160     * {@code import java.util.*;}.
161     *
162     * @param allow true to allow false to disallow
163     * @since 5.3
164     */
165    public void setAllowClassImports(boolean allow) {
166        allowClassImports = allow;
167    }
168
169    /**
170     * Setter to control whether to allow starred static member imports like
171     * {@code import static org.junit.Assert.*;}.
172     *
173     * @param allow true to allow false to disallow
174     * @since 5.3
175     */
176    public void setAllowStaticMemberImports(boolean allow) {
177        allowStaticMemberImports = allow;
178    }
179
180    @Override
181    public void visitToken(final DetailAST ast) {
182        if (ast.getType() == TokenTypes.IMPORT) {
183            if (!allowClassImports) {
184                final DetailAST startingDot = ast.getFirstChild();
185                logsStarredImportViolation(startingDot);
186            }
187        }
188        else if (!allowStaticMemberImports) {
189            // must navigate past the static keyword
190            final DetailAST startingDot = ast.getFirstChild().getNextSibling();
191            logsStarredImportViolation(startingDot);
192        }
193    }
194
195    /**
196     * Gets the full import identifier.  If the import is a starred import and
197     * it's not excluded then a violation is logged.
198     *
199     * @param startingDot the starting dot for the import statement
200     */
201    private void logsStarredImportViolation(DetailAST startingDot) {
202        final FullIdent name = FullIdent.createFullIdent(startingDot);
203        final String importText = name.getText();
204        if (importText.endsWith(STAR_IMPORT_SUFFIX) && !excludes.contains(importText)) {
205            log(startingDot, MSG_KEY, importText);
206        }
207    }
208
209}