001/////////////////////////////////////////////////////////////////////////////////////////////// 002// checkstyle: Checks Java source code and other text files for adherence to a set of rules. 003// Copyright (C) 2001-2025 the original author or authors. 004// 005// This library is free software; you can redistribute it and/or 006// modify it under the terms of the GNU Lesser General Public 007// License as published by the Free Software Foundation; either 008// version 2.1 of the License, or (at your option) any later version. 009// 010// This library is distributed in the hope that it will be useful, 011// but WITHOUT ANY WARRANTY; without even the implied warranty of 012// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU 013// Lesser General Public License for more details. 014// 015// You should have received a copy of the GNU Lesser General Public 016// License along with this library; if not, write to the Free Software 017// Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA 018/////////////////////////////////////////////////////////////////////////////////////////////// 019 020package com.puppycrawl.tools.checkstyle.checks.naming; 021 022import java.util.Arrays; 023import java.util.HashSet; 024import java.util.LinkedList; 025import java.util.List; 026import java.util.Set; 027import java.util.stream.Collectors; 028 029import com.puppycrawl.tools.checkstyle.StatelessCheck; 030import com.puppycrawl.tools.checkstyle.api.AbstractCheck; 031import com.puppycrawl.tools.checkstyle.api.DetailAST; 032import com.puppycrawl.tools.checkstyle.api.TokenTypes; 033import com.puppycrawl.tools.checkstyle.utils.CheckUtil; 034import com.puppycrawl.tools.checkstyle.utils.CommonUtil; 035 036/** 037 * <div> 038 * Validates abbreviations (consecutive capital letters) length in 039 * identifier name, it also allows to enforce camel case naming. Please read more at 040 * <a href="https://checkstyle.org/styleguides/google-java-style-20250426/javaguide.html#s5.3-camel-case"> 041 * Google Style Guide</a> to get to know how to avoid long abbreviations in names. 042 * </div> 043 * 044 * <p>'_' is considered as word separator in identifier name.</p> 045 * 046 * <p> 047 * {@code allowedAbbreviationLength} specifies how many consecutive capital letters are 048 * allowed in the identifier. 049 * A value of <i>3</i> indicates that up to 4 consecutive capital letters are allowed, 050 * one after the other, before a violation is printed. The identifier 'MyTEST' would be 051 * allowed, but 'MyTESTS' would not be. 052 * A value of <i>0</i> indicates that only 1 consecutive capital letter is allowed. This 053 * is what should be used to enforce strict camel casing. The identifier 'MyTest' would 054 * be allowed, but 'MyTEst' would not be. 055 * </p> 056 * 057 * <p> 058 * {@code ignoreFinal}, {@code ignoreStatic}, and {@code ignoreStaticFinal} 059 * control whether variables with the respective modifiers are to be ignored. 060 * Note that a variable that is both static and final will always be considered under 061 * {@code ignoreStaticFinal} only, regardless of the values of {@code ignoreFinal} 062 * and {@code ignoreStatic}. So for example if {@code ignoreStatic} is true but 063 * {@code ignoreStaticFinal} is false, then static final variables will not be ignored. 064 * </p> 065 * 066 * @since 5.8 067 */ 068@StatelessCheck 069public class AbbreviationAsWordInNameCheck extends AbstractCheck { 070 071 /** 072 * Warning message key. 073 */ 074 public static final String MSG_KEY = "abbreviation.as.word"; 075 076 /** 077 * The default value of "allowedAbbreviationLength" option. 078 */ 079 private static final int DEFAULT_ALLOWED_ABBREVIATIONS_LENGTH = 3; 080 081 /** 082 * Indicate the number of consecutive capital letters allowed in 083 * targeted identifiers (abbreviations in the classes, interfaces, variables 084 * and methods names, ... ). 085 */ 086 private int allowedAbbreviationLength = 087 DEFAULT_ALLOWED_ABBREVIATIONS_LENGTH; 088 089 /** 090 * Specify abbreviations that must be skipped for checking. 091 */ 092 private Set<String> allowedAbbreviations = new HashSet<>(); 093 094 /** Allow to skip variables with {@code final} modifier. */ 095 private boolean ignoreFinal = true; 096 097 /** Allow to skip variables with {@code static} modifier. */ 098 private boolean ignoreStatic = true; 099 100 /** Allow to skip variables with both {@code static} and {@code final} modifiers. */ 101 private boolean ignoreStaticFinal = true; 102 103 /** 104 * Allow to ignore methods tagged with {@code @Override} annotation (that 105 * usually mean inherited name). 106 */ 107 private boolean ignoreOverriddenMethods = true; 108 109 /** 110 * Setter to allow to skip variables with {@code final} modifier. 111 * 112 * @param ignoreFinal 113 * Defines if ignore variables with 'final' modifier or not. 114 * @since 5.8 115 */ 116 public void setIgnoreFinal(boolean ignoreFinal) { 117 this.ignoreFinal = ignoreFinal; 118 } 119 120 /** 121 * Setter to allow to skip variables with {@code static} modifier. 122 * 123 * @param ignoreStatic 124 * Defines if ignore variables with 'static' modifier or not. 125 * @since 5.8 126 */ 127 public void setIgnoreStatic(boolean ignoreStatic) { 128 this.ignoreStatic = ignoreStatic; 129 } 130 131 /** 132 * Setter to allow to skip variables with both {@code static} and {@code final} modifiers. 133 * 134 * @param ignoreStaticFinal 135 * Defines if ignore variables with both 'static' and 'final' modifiers or not. 136 * @since 8.32 137 */ 138 public void setIgnoreStaticFinal(boolean ignoreStaticFinal) { 139 this.ignoreStaticFinal = ignoreStaticFinal; 140 } 141 142 /** 143 * Setter to allow to ignore methods tagged with {@code @Override} 144 * annotation (that usually mean inherited name). 145 * 146 * @param ignoreOverriddenMethods 147 * Defines if ignore methods with "@Override" annotation or not. 148 * @since 5.8 149 */ 150 public void setIgnoreOverriddenMethods(boolean ignoreOverriddenMethods) { 151 this.ignoreOverriddenMethods = ignoreOverriddenMethods; 152 } 153 154 /** 155 * Setter to indicate the number of consecutive capital letters allowed 156 * in targeted identifiers (abbreviations in the classes, interfaces, 157 * variables and methods names, ... ). 158 * 159 * @param allowedAbbreviationLength amount of allowed capital letters in 160 * abbreviation. 161 * @since 5.8 162 */ 163 public void setAllowedAbbreviationLength(int allowedAbbreviationLength) { 164 this.allowedAbbreviationLength = allowedAbbreviationLength; 165 } 166 167 /** 168 * Setter to specify abbreviations that must be skipped for checking. 169 * 170 * @param allowedAbbreviations abbreviations that must be 171 * skipped from checking. 172 * @since 5.8 173 */ 174 public void setAllowedAbbreviations(String... allowedAbbreviations) { 175 if (allowedAbbreviations != null) { 176 this.allowedAbbreviations = 177 Arrays.stream(allowedAbbreviations).collect(Collectors.toUnmodifiableSet()); 178 } 179 } 180 181 @Override 182 public int[] getDefaultTokens() { 183 return new int[] { 184 TokenTypes.CLASS_DEF, 185 TokenTypes.INTERFACE_DEF, 186 TokenTypes.ENUM_DEF, 187 TokenTypes.ANNOTATION_DEF, 188 TokenTypes.ANNOTATION_FIELD_DEF, 189 TokenTypes.PARAMETER_DEF, 190 TokenTypes.VARIABLE_DEF, 191 TokenTypes.METHOD_DEF, 192 TokenTypes.PATTERN_VARIABLE_DEF, 193 TokenTypes.RECORD_DEF, 194 TokenTypes.RECORD_COMPONENT_DEF, 195 }; 196 } 197 198 @Override 199 public int[] getAcceptableTokens() { 200 return new int[] { 201 TokenTypes.CLASS_DEF, 202 TokenTypes.INTERFACE_DEF, 203 TokenTypes.ENUM_DEF, 204 TokenTypes.ANNOTATION_DEF, 205 TokenTypes.ANNOTATION_FIELD_DEF, 206 TokenTypes.PARAMETER_DEF, 207 TokenTypes.VARIABLE_DEF, 208 TokenTypes.METHOD_DEF, 209 TokenTypes.ENUM_CONSTANT_DEF, 210 TokenTypes.PATTERN_VARIABLE_DEF, 211 TokenTypes.RECORD_DEF, 212 TokenTypes.RECORD_COMPONENT_DEF, 213 }; 214 } 215 216 @Override 217 public int[] getRequiredTokens() { 218 return CommonUtil.EMPTY_INT_ARRAY; 219 } 220 221 @Override 222 public void visitToken(DetailAST ast) { 223 if (!isIgnoreSituation(ast)) { 224 final DetailAST nameAst = ast.findFirstToken(TokenTypes.IDENT); 225 final String typeName = nameAst.getText(); 226 227 final String abbr = getDisallowedAbbreviation(typeName); 228 if (abbr != null) { 229 log(nameAst, MSG_KEY, typeName, allowedAbbreviationLength + 1); 230 } 231 } 232 } 233 234 /** 235 * Checks if it is an ignore situation. 236 * 237 * @param ast input DetailAST node. 238 * @return true if it is an ignore situation found for given input DetailAST 239 * node. 240 */ 241 private boolean isIgnoreSituation(DetailAST ast) { 242 final DetailAST modifiers = ast.getFirstChild(); 243 244 final boolean result; 245 if (ast.getType() == TokenTypes.VARIABLE_DEF) { 246 if (isInterfaceDeclaration(ast)) { 247 // field declarations in interface are static/final 248 result = ignoreStaticFinal; 249 } 250 else { 251 result = hasIgnoredModifiers(modifiers); 252 } 253 } 254 else if (ast.getType() == TokenTypes.METHOD_DEF) { 255 result = ignoreOverriddenMethods && hasOverrideAnnotation(modifiers); 256 } 257 else { 258 result = CheckUtil.isReceiverParameter(ast); 259 } 260 return result; 261 } 262 263 /** 264 * Checks if a variable is to be ignored based on its modifiers. 265 * 266 * @param modifiers modifiers of the variable to be checked 267 * @return true if there is a modifier to be ignored 268 */ 269 private boolean hasIgnoredModifiers(DetailAST modifiers) { 270 final boolean isStatic = modifiers.findFirstToken(TokenTypes.LITERAL_STATIC) != null; 271 final boolean isFinal = modifiers.findFirstToken(TokenTypes.FINAL) != null; 272 final boolean result; 273 if (isStatic && isFinal) { 274 result = ignoreStaticFinal; 275 } 276 else { 277 result = ignoreStatic && isStatic || ignoreFinal && isFinal; 278 } 279 return result; 280 } 281 282 /** 283 * Check that variable definition in interface or @interface definition. 284 * 285 * @param variableDefAst variable definition. 286 * @return true if variable definition(variableDefAst) is in interface 287 * or @interface definition. 288 */ 289 private static boolean isInterfaceDeclaration(DetailAST variableDefAst) { 290 boolean result = false; 291 final DetailAST astBlock = variableDefAst.getParent(); 292 final DetailAST astParent2 = astBlock.getParent(); 293 294 if (astParent2.getType() == TokenTypes.INTERFACE_DEF 295 || astParent2.getType() == TokenTypes.ANNOTATION_DEF) { 296 result = true; 297 } 298 return result; 299 } 300 301 /** 302 * Checks that the method has "@Override" annotation. 303 * 304 * @param methodModifiersAST 305 * A DetailAST nod is related to the given method modifiers 306 * (MODIFIERS type). 307 * @return true if method has "@Override" annotation. 308 */ 309 private static boolean hasOverrideAnnotation(DetailAST methodModifiersAST) { 310 boolean result = false; 311 for (DetailAST child : getChildren(methodModifiersAST)) { 312 final DetailAST annotationIdent = child.findFirstToken(TokenTypes.IDENT); 313 314 if (annotationIdent != null && "Override".equals(annotationIdent.getText())) { 315 result = true; 316 break; 317 } 318 } 319 return result; 320 } 321 322 /** 323 * Gets the disallowed abbreviation contained in given String. 324 * 325 * @param str 326 * the given String. 327 * @return the disallowed abbreviation contained in given String as a 328 * separate String. 329 */ 330 private String getDisallowedAbbreviation(String str) { 331 int beginIndex = 0; 332 boolean abbrStarted = false; 333 String result = null; 334 335 for (int index = 0; index < str.length(); index++) { 336 final char symbol = str.charAt(index); 337 338 if (Character.isUpperCase(symbol)) { 339 if (!abbrStarted) { 340 abbrStarted = true; 341 beginIndex = index; 342 } 343 } 344 else if (abbrStarted) { 345 abbrStarted = false; 346 347 final int endIndex; 348 final int allowedLength; 349 if (symbol == '_') { 350 endIndex = index; 351 allowedLength = allowedAbbreviationLength + 1; 352 } 353 else { 354 endIndex = index - 1; 355 allowedLength = allowedAbbreviationLength; 356 } 357 result = getAbbreviationIfIllegal(str, beginIndex, endIndex, allowedLength); 358 if (result != null) { 359 break; 360 } 361 beginIndex = -1; 362 } 363 } 364 // if abbreviation at the end of name (example: scaleX) 365 if (abbrStarted) { 366 final int endIndex = str.length() - 1; 367 result = getAbbreviationIfIllegal(str, beginIndex, endIndex, allowedAbbreviationLength); 368 } 369 return result; 370 } 371 372 /** 373 * Get Abbreviation if it is illegal, where {@code beginIndex} and {@code endIndex} are 374 * inclusive indexes of a sequence of consecutive upper-case characters. 375 * 376 * @param str name 377 * @param beginIndex begin index 378 * @param endIndex end index 379 * @param allowedLength maximum allowed length for Abbreviation 380 * @return the abbreviation if it is bigger than required and not in the 381 * ignore list, otherwise {@code null} 382 */ 383 private String getAbbreviationIfIllegal(String str, int beginIndex, int endIndex, 384 int allowedLength) { 385 String result = null; 386 final int abbrLength = endIndex - beginIndex; 387 if (abbrLength > allowedLength) { 388 final String abbr = getAbbreviation(str, beginIndex, endIndex); 389 if (!allowedAbbreviations.contains(abbr)) { 390 result = abbr; 391 } 392 } 393 return result; 394 } 395 396 /** 397 * Gets the abbreviation, where {@code beginIndex} and {@code endIndex} are 398 * inclusive indexes of a sequence of consecutive upper-case characters. 399 * 400 * <p> 401 * The character at {@code endIndex} is only included in the abbreviation if 402 * it is the last character in the string; otherwise it is usually the first 403 * capital in the next word. 404 * </p> 405 * 406 * <p> 407 * For example, {@code getAbbreviation("getXMLParser", 3, 6)} returns "XML" 408 * (not "XMLP"), and so does {@code getAbbreviation("parseXML", 5, 7)}. 409 * </p> 410 * 411 * @param str name 412 * @param beginIndex begin index 413 * @param endIndex end index 414 * @return the specified abbreviation 415 */ 416 private static String getAbbreviation(String str, int beginIndex, int endIndex) { 417 final String result; 418 if (endIndex == str.length() - 1) { 419 result = str.substring(beginIndex); 420 } 421 else { 422 result = str.substring(beginIndex, endIndex); 423 } 424 return result; 425 } 426 427 /** 428 * Gets all the children which are one level below on the current DetailAST 429 * parent node. 430 * 431 * @param node 432 * Current parent node. 433 * @return The list of children one level below on the current parent node. 434 */ 435 private static List<DetailAST> getChildren(final DetailAST node) { 436 final List<DetailAST> result = new LinkedList<>(); 437 DetailAST curNode = node.getFirstChild(); 438 while (curNode != null) { 439 result.add(curNode); 440 curNode = curNode.getNextSibling(); 441 } 442 return result; 443 } 444 445}