001/////////////////////////////////////////////////////////////////////////////////////////////// 002// checkstyle: Checks Java source code and other text files for adherence to a set of rules. 003// Copyright (C) 2001-2025 the original author or authors. 004// 005// This library is free software; you can redistribute it and/or 006// modify it under the terms of the GNU Lesser General Public 007// License as published by the Free Software Foundation; either 008// version 2.1 of the License, or (at your option) any later version. 009// 010// This library is distributed in the hope that it will be useful, 011// but WITHOUT ANY WARRANTY; without even the implied warranty of 012// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU 013// Lesser General Public License for more details. 014// 015// You should have received a copy of the GNU Lesser General Public 016// License along with this library; if not, write to the Free Software 017// Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA 018/////////////////////////////////////////////////////////////////////////////////////////////// 019 020package com.puppycrawl.tools.checkstyle.checks.imports; 021 022import java.util.HashSet; 023import java.util.Set; 024 025import com.puppycrawl.tools.checkstyle.StatelessCheck; 026import com.puppycrawl.tools.checkstyle.api.AbstractCheck; 027import com.puppycrawl.tools.checkstyle.api.DetailAST; 028import com.puppycrawl.tools.checkstyle.api.FullIdent; 029import com.puppycrawl.tools.checkstyle.api.TokenTypes; 030 031/** 032 * <div> 033 * Checks that there are no import statements that use the {@code *} notation. 034 * </div> 035 * 036 * <p> 037 * Rationale: Importing all classes from a package or static 038 * members from a class leads to tight coupling between packages 039 * or classes and might lead to problems when a new version of a 040 * library introduces name clashes. 041 * </p> 042 * 043 * <p> 044 * Notes: 045 * Note that property {@code excludes} is not recursive, subpackages of excluded 046 * packages are not automatically excluded. 047 * </p> 048 * 049 * @since 3.0 050 */ 051@StatelessCheck 052public class AvoidStarImportCheck 053 extends AbstractCheck { 054 055 /** 056 * A key is pointing to the warning message text in "messages.properties" 057 * file. 058 */ 059 public static final String MSG_KEY = "import.avoidStar"; 060 061 /** Suffix for the star import. */ 062 private static final String STAR_IMPORT_SUFFIX = ".*"; 063 064 /** 065 * Specify packages where starred class imports are 066 * allowed and classes where starred static member imports are allowed. 067 */ 068 private final Set<String> excludes = new HashSet<>(); 069 070 /** 071 * Control whether to allow starred class imports like 072 * {@code import java.util.*;}. 073 */ 074 private boolean allowClassImports; 075 076 /** 077 * Control whether to allow starred static member imports like 078 * {@code import static org.junit.Assert.*;}. 079 */ 080 private boolean allowStaticMemberImports; 081 082 @Override 083 public int[] getDefaultTokens() { 084 return getRequiredTokens(); 085 } 086 087 @Override 088 public int[] getAcceptableTokens() { 089 return getRequiredTokens(); 090 } 091 092 @Override 093 public int[] getRequiredTokens() { 094 // original implementation checks both IMPORT and STATIC_IMPORT tokens to avoid ".*" imports 095 // however user can allow using "import" or "import static" 096 // by configuring allowClassImports and allowStaticMemberImports 097 // To avoid potential confusion when user specifies conflicting options on configuration 098 // (see example below) we are adding both tokens to Required list 099 // <module name="AvoidStarImport"> 100 // <property name="tokens" value="IMPORT"/> 101 // <property name="allowStaticMemberImports" value="false"/> 102 // </module> 103 return new int[] {TokenTypes.IMPORT, TokenTypes.STATIC_IMPORT}; 104 } 105 106 /** 107 * Setter to specify packages where starred class imports are 108 * allowed and classes where starred static member imports are allowed. 109 * 110 * @param excludesParam package names/fully-qualifies class names 111 * where star imports are ok 112 * @since 3.2 113 */ 114 public void setExcludes(String... excludesParam) { 115 for (final String exclude : excludesParam) { 116 if (exclude.endsWith(STAR_IMPORT_SUFFIX)) { 117 excludes.add(exclude); 118 } 119 else { 120 excludes.add(exclude + STAR_IMPORT_SUFFIX); 121 } 122 } 123 } 124 125 /** 126 * Setter to control whether to allow starred class imports like 127 * {@code import java.util.*;}. 128 * 129 * @param allow true to allow false to disallow 130 * @since 5.3 131 */ 132 public void setAllowClassImports(boolean allow) { 133 allowClassImports = allow; 134 } 135 136 /** 137 * Setter to control whether to allow starred static member imports like 138 * {@code import static org.junit.Assert.*;}. 139 * 140 * @param allow true to allow false to disallow 141 * @since 5.3 142 */ 143 public void setAllowStaticMemberImports(boolean allow) { 144 allowStaticMemberImports = allow; 145 } 146 147 @Override 148 public void visitToken(final DetailAST ast) { 149 if (ast.getType() == TokenTypes.IMPORT) { 150 if (!allowClassImports) { 151 final DetailAST startingDot = ast.getFirstChild(); 152 logsStarredImportViolation(startingDot); 153 } 154 } 155 else if (!allowStaticMemberImports) { 156 // must navigate past the static keyword 157 final DetailAST startingDot = ast.getFirstChild().getNextSibling(); 158 logsStarredImportViolation(startingDot); 159 } 160 } 161 162 /** 163 * Gets the full import identifier. If the import is a starred import and 164 * it's not excluded then a violation is logged. 165 * 166 * @param startingDot the starting dot for the import statement 167 */ 168 private void logsStarredImportViolation(DetailAST startingDot) { 169 final FullIdent name = FullIdent.createFullIdent(startingDot); 170 final String importText = name.getText(); 171 if (importText.endsWith(STAR_IMPORT_SUFFIX) && !excludes.contains(importText)) { 172 log(startingDot, MSG_KEY, importText); 173 } 174 } 175 176}