001/////////////////////////////////////////////////////////////////////////////////////////////// 002// checkstyle: Checks Java source code and other text files for adherence to a set of rules. 003// Copyright (C) 2001-2025 the original author or authors. 004// 005// This library is free software; you can redistribute it and/or 006// modify it under the terms of the GNU Lesser General Public 007// License as published by the Free Software Foundation; either 008// version 2.1 of the License, or (at your option) any later version. 009// 010// This library is distributed in the hope that it will be useful, 011// but WITHOUT ANY WARRANTY; without even the implied warranty of 012// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU 013// Lesser General Public License for more details. 014// 015// You should have received a copy of the GNU Lesser General Public 016// License along with this library; if not, write to the Free Software 017// Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA 018/////////////////////////////////////////////////////////////////////////////////////////////// 019 020package com.puppycrawl.tools.checkstyle.checks.coding; 021 022import java.util.ArrayList; 023import java.util.Collections; 024import java.util.List; 025 026import com.puppycrawl.tools.checkstyle.StatelessCheck; 027import com.puppycrawl.tools.checkstyle.api.AbstractCheck; 028import com.puppycrawl.tools.checkstyle.api.DetailAST; 029import com.puppycrawl.tools.checkstyle.api.TokenTypes; 030import com.puppycrawl.tools.checkstyle.utils.TokenUtil; 031 032/** 033 * <div> 034 * Ensures that {@code when} is used instead of a single {@code if} 035 * statement inside a case block. 036 * </div> 037 * 038 * <p> 039 * Rationale: Java 21 has introduced enhancements for switch statements and expressions 040 * that allow the use of patterns in case labels. The {@code when} keyword is used to specify 041 * condition for a case label, also called as guarded case labels. This syntax is more readable 042 * and concise than the single {@code if} statement inside the pattern match block. 043 * </p> 044 * 045 * <p> 046 * See the <a href="https://docs.oracle.com/javase/specs/jls/se22/html/jls-14.html#jls-Guard"> 047 * Java Language Specification</a> for more information about guarded case labels. 048 * </p> 049 * 050 * <p> 051 * See the <a href="https://docs.oracle.com/javase/specs/jls/se22/html/jls-14.html#jls-14.30"> 052 * Java Language Specification</a> for more information about patterns. 053 * </p> 054 * 055 * @since 10.18.0 056 */ 057 058@StatelessCheck 059public class WhenShouldBeUsedCheck extends AbstractCheck { 060 061 /** 062 * A key is pointing to the warning message text in "messages.properties" 063 * file. 064 */ 065 public static final String MSG_KEY = "when.should.be.used"; 066 067 @Override 068 public int[] getDefaultTokens() { 069 return getRequiredTokens(); 070 } 071 072 @Override 073 public int[] getAcceptableTokens() { 074 return getRequiredTokens(); 075 } 076 077 @Override 078 public int[] getRequiredTokens() { 079 return new int[] {TokenTypes.LITERAL_CASE}; 080 } 081 082 @Override 083 public void visitToken(DetailAST ast) { 084 final boolean hasPatternLabel = hasPatternLabel(ast); 085 final DetailAST statementList = getStatementList(ast); 086 // until https://github.com/checkstyle/checkstyle/issues/15270 087 final boolean isInSwitchRule = ast.getParent().getType() == TokenTypes.SWITCH_RULE; 088 089 if (hasPatternLabel && statementList != null && isInSwitchRule) { 090 final List<DetailAST> blockStatements = getBlockStatements(statementList); 091 092 final boolean hasAcceptableStatementsOnly = blockStatements.stream() 093 .allMatch(WhenShouldBeUsedCheck::isAcceptableStatement); 094 095 final boolean hasSingleIfWithNoElse = blockStatements.stream() 096 .filter(WhenShouldBeUsedCheck::isSingleIfWithNoElse) 097 .count() == 1; 098 099 if (hasAcceptableStatementsOnly && hasSingleIfWithNoElse) { 100 log(ast, MSG_KEY); 101 } 102 } 103 } 104 105 /** 106 * Get the statement list token of the case block. 107 * 108 * @param caseAST the AST node representing {@code LITERAL_CASE} 109 * @return the AST node representing {@code SLIST} of the current case 110 */ 111 private static DetailAST getStatementList(DetailAST caseAST) { 112 final DetailAST caseParent = caseAST.getParent(); 113 return caseParent.findFirstToken(TokenTypes.SLIST); 114 } 115 116 /** 117 * Get all statements inside the case block. 118 * 119 * @param statementList the AST node representing {@code SLIST} of the current case 120 * @return statements inside the current case block 121 */ 122 private static List<DetailAST> getBlockStatements(DetailAST statementList) { 123 final List<DetailAST> blockStatements = new ArrayList<>(); 124 DetailAST ast = statementList.getFirstChild(); 125 while (ast != null) { 126 blockStatements.add(ast); 127 ast = ast.getNextSibling(); 128 } 129 return Collections.unmodifiableList(blockStatements); 130 } 131 132 /** 133 * Check if the statement is an acceptable statement inside the case block. 134 * If these statements are the only ones in the case block, this case 135 * can be considered a violation. If at least one of the statements 136 * is not acceptable, this case can not be a violation. 137 * 138 * @param ast the AST node representing the statement 139 * @return true if the statement is an acceptable statement, false otherwise 140 */ 141 private static boolean isAcceptableStatement(DetailAST ast) { 142 final int[] acceptableChildrenOfSlist = { 143 TokenTypes.LITERAL_IF, 144 TokenTypes.LITERAL_BREAK, 145 TokenTypes.EMPTY_STAT, 146 TokenTypes.RCURLY, 147 }; 148 return TokenUtil.isOfType(ast, acceptableChildrenOfSlist); 149 } 150 151 /** 152 * Check if the case block has a pattern variable definition 153 * or a record pattern definition. 154 * 155 * @param caseAST the AST node representing {@code LITERAL_CASE} 156 * @return true if the case block has a pattern label, false otherwise 157 */ 158 private static boolean hasPatternLabel(DetailAST caseAST) { 159 return caseAST.findFirstToken(TokenTypes.PATTERN_VARIABLE_DEF) != null 160 || caseAST.findFirstToken(TokenTypes.RECORD_PATTERN_DEF) != null 161 || caseAST.findFirstToken(TokenTypes.PATTERN_DEF) != null; 162 } 163 164 /** 165 * Check if the case block statement is a single if statement with no else branch. 166 * 167 * @param statement statement to check inside the current case block 168 * @return true if the statement is a single if statement with no else branch, false otherwise 169 */ 170 private static boolean isSingleIfWithNoElse(DetailAST statement) { 171 return statement.getType() == TokenTypes.LITERAL_IF 172 && statement.findFirstToken(TokenTypes.LITERAL_ELSE) == null; 173 } 174 175}