001/////////////////////////////////////////////////////////////////////////////////////////////// 002// checkstyle: Checks Java source code and other text files for adherence to a set of rules. 003// Copyright (C) 2001-2025 the original author or authors. 004// 005// This library is free software; you can redistribute it and/or 006// modify it under the terms of the GNU Lesser General Public 007// License as published by the Free Software Foundation; either 008// version 2.1 of the License, or (at your option) any later version. 009// 010// This library is distributed in the hope that it will be useful, 011// but WITHOUT ANY WARRANTY; without even the implied warranty of 012// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU 013// Lesser General Public License for more details. 014// 015// You should have received a copy of the GNU Lesser General Public 016// License along with this library; if not, write to the Free Software 017// Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA 018/////////////////////////////////////////////////////////////////////////////////////////////// 019 020package com.puppycrawl.tools.checkstyle.checks.coding; 021 022import java.util.HashMap; 023import java.util.Map; 024 025import com.puppycrawl.tools.checkstyle.FileStatefulCheck; 026import com.puppycrawl.tools.checkstyle.api.AbstractCheck; 027import com.puppycrawl.tools.checkstyle.api.DetailAST; 028import com.puppycrawl.tools.checkstyle.api.FullIdent; 029import com.puppycrawl.tools.checkstyle.api.TokenTypes; 030import com.puppycrawl.tools.checkstyle.utils.CheckUtil; 031 032/** 033 * <div> 034 * Checks that classes that either override {@code equals()} or {@code hashCode()} also 035 * overrides the other. 036 * This check only verifies that the method declarations match {@code Object.equals(Object)} and 037 * {@code Object.hashCode()} exactly to be considered an override. This check does not verify 038 * invalid method names, parameters other than {@code Object}, or anything else. 039 * </div> 040 * 041 * <p> 042 * Rationale: The contract of {@code equals()} and {@code hashCode()} requires that 043 * equal objects have the same hashCode. Therefore, whenever you override 044 * {@code equals()} you must override {@code hashCode()} to ensure that your class can 045 * be used in hash-based collections. 046 * </p> 047 * 048 * @since 3.0 049 */ 050@FileStatefulCheck 051public class EqualsHashCodeCheck 052 extends AbstractCheck { 053 054 // implementation note: we have to use the following members to 055 // keep track of definitions in different inner classes 056 057 /** 058 * A key is pointing to the warning message text in "messages.properties" 059 * file. 060 */ 061 public static final String MSG_KEY_HASHCODE = "equals.noHashCode"; 062 063 /** 064 * A key is pointing to the warning message text in "messages.properties" 065 * file. 066 */ 067 public static final String MSG_KEY_EQUALS = "equals.noEquals"; 068 069 /** Maps OBJ_BLOCK to the method definition of equals(). */ 070 private final Map<DetailAST, DetailAST> objBlockWithEquals = new HashMap<>(); 071 072 /** Maps OBJ_BLOCKs to the method definition of hashCode(). */ 073 private final Map<DetailAST, DetailAST> objBlockWithHashCode = new HashMap<>(); 074 075 @Override 076 public int[] getDefaultTokens() { 077 return getRequiredTokens(); 078 } 079 080 @Override 081 public int[] getAcceptableTokens() { 082 return getRequiredTokens(); 083 } 084 085 @Override 086 public int[] getRequiredTokens() { 087 return new int[] {TokenTypes.METHOD_DEF}; 088 } 089 090 @Override 091 public void beginTree(DetailAST rootAST) { 092 objBlockWithEquals.clear(); 093 objBlockWithHashCode.clear(); 094 } 095 096 @Override 097 public void visitToken(DetailAST ast) { 098 if (isEqualsMethod(ast)) { 099 objBlockWithEquals.put(ast.getParent(), ast); 100 } 101 else if (isHashCodeMethod(ast)) { 102 objBlockWithHashCode.put(ast.getParent(), ast); 103 } 104 } 105 106 /** 107 * Determines if an AST is a valid Equals method implementation. 108 * 109 * @param ast the AST to check 110 * @return true if the {code ast} is an Equals method. 111 */ 112 private static boolean isEqualsMethod(DetailAST ast) { 113 final DetailAST modifiers = ast.getFirstChild(); 114 final DetailAST parameters = ast.findFirstToken(TokenTypes.PARAMETERS); 115 116 return CheckUtil.isEqualsMethod(ast) 117 && isObjectParam(parameters.getFirstChild()) 118 && (ast.findFirstToken(TokenTypes.SLIST) != null 119 || modifiers.findFirstToken(TokenTypes.LITERAL_NATIVE) != null); 120 } 121 122 /** 123 * Determines if an AST is a valid HashCode method implementation. 124 * 125 * @param ast the AST to check 126 * @return true if the {code ast} is a HashCode method. 127 */ 128 private static boolean isHashCodeMethod(DetailAST ast) { 129 final DetailAST modifiers = ast.getFirstChild(); 130 final DetailAST methodName = ast.findFirstToken(TokenTypes.IDENT); 131 final DetailAST parameters = ast.findFirstToken(TokenTypes.PARAMETERS); 132 133 return "hashCode".equals(methodName.getText()) 134 && parameters.getFirstChild() == null 135 && (ast.findFirstToken(TokenTypes.SLIST) != null 136 || modifiers.findFirstToken(TokenTypes.LITERAL_NATIVE) != null); 137 } 138 139 /** 140 * Determines if an AST is a formal param of type Object. 141 * 142 * @param paramNode the AST to check 143 * @return true if firstChild is a parameter of an Object type. 144 */ 145 private static boolean isObjectParam(DetailAST paramNode) { 146 final DetailAST typeNode = paramNode.findFirstToken(TokenTypes.TYPE); 147 final FullIdent fullIdent = FullIdent.createFullIdentBelow(typeNode); 148 final String name = fullIdent.getText(); 149 return "Object".equals(name) || "java.lang.Object".equals(name); 150 } 151 152 @Override 153 public void finishTree(DetailAST rootAST) { 154 objBlockWithEquals 155 .entrySet().stream().filter(detailASTDetailASTEntry -> { 156 return objBlockWithHashCode.remove(detailASTDetailASTEntry.getKey()) == null; 157 }).forEach(detailASTDetailASTEntry -> { 158 final DetailAST equalsAST = detailASTDetailASTEntry.getValue(); 159 log(equalsAST, MSG_KEY_HASHCODE); 160 }); 161 objBlockWithHashCode.forEach((key, equalsAST) -> log(equalsAST, MSG_KEY_EQUALS)); 162 } 163 164}