001/////////////////////////////////////////////////////////////////////////////////////////////// 002// checkstyle: Checks Java source code and other text files for adherence to a set of rules. 003// Copyright (C) 2001-2026 the original author or authors. 004// 005// This library is free software; you can redistribute it and/or 006// modify it under the terms of the GNU Lesser General Public 007// License as published by the Free Software Foundation; either 008// version 2.1 of the License, or (at your option) any later version. 009// 010// This library is distributed in the hope that it will be useful, 011// but WITHOUT ANY WARRANTY; without even the implied warranty of 012// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU 013// Lesser General Public License for more details. 014// 015// You should have received a copy of the GNU Lesser General Public 016// License along with this library; if not, write to the Free Software 017// Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA 018/////////////////////////////////////////////////////////////////////////////////////////////// 019 020package com.puppycrawl.tools.checkstyle.checks.design; 021 022import java.util.ArrayDeque; 023import java.util.Deque; 024import java.util.regex.Pattern; 025 026import com.puppycrawl.tools.checkstyle.FileStatefulCheck; 027import com.puppycrawl.tools.checkstyle.api.AbstractCheck; 028import com.puppycrawl.tools.checkstyle.api.DetailAST; 029import com.puppycrawl.tools.checkstyle.api.TokenTypes; 030 031/** 032 * <div> 033 * Ensures that exception classes (classes with names conforming to some pattern 034 * and explicitly extending classes with names conforming to other 035 * pattern) are immutable, that is, that they have only final fields. 036 * </div> 037 * 038 * <p> 039 * The current algorithm is very simple: it checks that all members of exception are final. 040 * The user can still mutate an exception's instance (e.g. Throwable has a method called 041 * {@code setStackTrace} which changes the exception's stack trace). But, at least, all 042 * information provided by this exception type is unchangeable. 043 * </p> 044 * 045 * <p> 046 * Rationale: Exception instances should represent an error 047 * condition. Having non-final fields not only allows the state to be 048 * modified by accident and therefore mask the original condition but 049 * also allows developers to accidentally forget to set the initial state. 050 * In both cases, code catching the exception could draw incorrect 051 * conclusions based on the state. 052 * </p> 053 * 054 * @since 3.2 055 */ 056@FileStatefulCheck 057public final class MutableExceptionCheck extends AbstractCheck { 058 059 /** 060 * A key is pointing to the warning message text in "messages.properties" 061 * file. 062 */ 063 public static final String MSG_KEY = "mutable.exception"; 064 065 /** Default value for format and extendedClassNameFormat properties. */ 066 private static final String DEFAULT_FORMAT = "^.*Exception$|^.*Error$|^.*Throwable$"; 067 /** Stack of checking information for classes. */ 068 private final Deque<Boolean> checkingStack = new ArrayDeque<>(); 069 /** Specify pattern for extended class names. */ 070 private Pattern extendedClassNameFormat = Pattern.compile(DEFAULT_FORMAT); 071 /** Should we check current class or not. */ 072 private boolean checking; 073 /** Specify pattern for exception class names. */ 074 private Pattern format = extendedClassNameFormat; 075 076 /** 077 * Creates a new {@code MutableExceptionCheck} instance. 078 */ 079 public MutableExceptionCheck() { 080 // no code by default 081 } 082 083 /** 084 * Setter to specify pattern for extended class names. 085 * 086 * @param extendedClassNameFormat a {@code String} value 087 * @since 6.2 088 */ 089 public void setExtendedClassNameFormat(Pattern extendedClassNameFormat) { 090 this.extendedClassNameFormat = extendedClassNameFormat; 091 } 092 093 /** 094 * Setter to specify pattern for exception class names. 095 * 096 * @param pattern the new pattern 097 * @since 3.2 098 */ 099 public void setFormat(Pattern pattern) { 100 format = pattern; 101 } 102 103 @Override 104 public int[] getDefaultTokens() { 105 return getRequiredTokens(); 106 } 107 108 @Override 109 public int[] getRequiredTokens() { 110 return new int[] {TokenTypes.CLASS_DEF, TokenTypes.VARIABLE_DEF}; 111 } 112 113 @Override 114 public int[] getAcceptableTokens() { 115 return getRequiredTokens(); 116 } 117 118 @Override 119 public void visitToken(DetailAST ast) { 120 switch (ast.getType()) { 121 case TokenTypes.CLASS_DEF -> visitClassDef(ast); 122 case TokenTypes.VARIABLE_DEF -> visitVariableDef(ast); 123 default -> throw new IllegalStateException(ast.toString()); 124 } 125 } 126 127 @Override 128 public void leaveToken(DetailAST ast) { 129 if (ast.getType() == TokenTypes.CLASS_DEF) { 130 leaveClassDef(); 131 } 132 } 133 134 /** 135 * Called when we start processing class definition. 136 * 137 * @param ast class definition node 138 */ 139 private void visitClassDef(DetailAST ast) { 140 checkingStack.push(checking); 141 checking = isNamedAsException(ast) && isExtendedClassNamedAsException(ast); 142 } 143 144 /** Called when we leave class definition. */ 145 private void leaveClassDef() { 146 checking = checkingStack.pop(); 147 } 148 149 /** 150 * Checks variable definition. 151 * 152 * @param ast variable def node for check 153 */ 154 private void visitVariableDef(DetailAST ast) { 155 if (checking && ast.getParent().getType() == TokenTypes.OBJBLOCK) { 156 final DetailAST modifiersAST = 157 ast.findFirstToken(TokenTypes.MODIFIERS); 158 159 if (modifiersAST.findFirstToken(TokenTypes.FINAL) == null) { 160 log(ast, MSG_KEY, ast.findFirstToken(TokenTypes.IDENT).getText()); 161 } 162 } 163 } 164 165 /** 166 * Checks that a class name conforms to specified format. 167 * 168 * @param ast class definition node 169 * @return true if a class name conforms to specified format 170 */ 171 private boolean isNamedAsException(DetailAST ast) { 172 final String className = ast.findFirstToken(TokenTypes.IDENT).getText(); 173 return format.matcher(className).find(); 174 } 175 176 /** 177 * Checks that if extended class name conforms to specified format. 178 * 179 * @param ast class definition node 180 * @return true if extended class name conforms to specified format 181 */ 182 private boolean isExtendedClassNamedAsException(DetailAST ast) { 183 boolean result = false; 184 final DetailAST extendsClause = ast.findFirstToken(TokenTypes.EXTENDS_CLAUSE); 185 if (extendsClause != null) { 186 DetailAST currentNode = extendsClause; 187 while (currentNode.getLastChild() != null) { 188 currentNode = currentNode.getLastChild(); 189 } 190 final String extendedClassName = currentNode.getText(); 191 result = extendedClassNameFormat.matcher(extendedClassName).matches(); 192 } 193 return result; 194 } 195 196}