001/////////////////////////////////////////////////////////////////////////////////////////////// 002// checkstyle: Checks Java source code and other text files for adherence to a set of rules. 003// Copyright (C) 2001-2026 the original author or authors. 004// 005// This library is free software; you can redistribute it and/or 006// modify it under the terms of the GNU Lesser General Public 007// License as published by the Free Software Foundation; either 008// version 2.1 of the License, or (at your option) any later version. 009// 010// This library is distributed in the hope that it will be useful, 011// but WITHOUT ANY WARRANTY; without even the implied warranty of 012// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU 013// Lesser General Public License for more details. 014// 015// You should have received a copy of the GNU Lesser General Public 016// License along with this library; if not, write to the Free Software 017// Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA 018/////////////////////////////////////////////////////////////////////////////////////////////// 019 020package com.puppycrawl.tools.checkstyle.checks.coding; 021 022import java.util.HashMap; 023import java.util.Map; 024 025import com.puppycrawl.tools.checkstyle.FileStatefulCheck; 026import com.puppycrawl.tools.checkstyle.api.AbstractCheck; 027import com.puppycrawl.tools.checkstyle.api.DetailAST; 028import com.puppycrawl.tools.checkstyle.api.FullIdent; 029import com.puppycrawl.tools.checkstyle.api.TokenTypes; 030import com.puppycrawl.tools.checkstyle.utils.CheckUtil; 031 032/** 033 * <div> 034 * Checks that classes that either override {@code equals()} or {@code hashCode()} also 035 * overrides the other. 036 * This check only verifies that the method declarations match {@code Object.equals(Object)} and 037 * {@code Object.hashCode()} exactly to be considered an override. This check does not verify 038 * invalid method names, parameters other than {@code Object}, or anything else. 039 * </div> 040 * 041 * <p> 042 * Rationale: The contract of {@code equals()} and {@code hashCode()} requires that 043 * equal objects have the same hashCode. Therefore, whenever you override 044 * {@code equals()} you must override {@code hashCode()} to ensure that your class can 045 * be used in hash-based collections. 046 * </p> 047 * 048 * @since 3.0 049 */ 050@FileStatefulCheck 051public class EqualsHashCodeCheck 052 extends AbstractCheck { 053 054 // implementation note: we have to use the following members to 055 // keep track of definitions in different inner classes 056 057 /** 058 * A key is pointing to the warning message text in "messages.properties" 059 * file. 060 */ 061 public static final String MSG_KEY_HASHCODE = "equals.noHashCode"; 062 063 /** 064 * A key is pointing to the warning message text in "messages.properties" 065 * file. 066 */ 067 public static final String MSG_KEY_EQUALS = "equals.noEquals"; 068 069 /** Maps OBJ_BLOCK to the method definition of equals(). */ 070 private final Map<DetailAST, DetailAST> objBlockWithEquals = new HashMap<>(); 071 072 /** Maps OBJ_BLOCKs to the method definition of hashCode(). */ 073 private final Map<DetailAST, DetailAST> objBlockWithHashCode = new HashMap<>(); 074 075 /** 076 * Creates a new {@code EqualsHashCodeCheck} instance. 077 */ 078 public EqualsHashCodeCheck() { 079 // no code by default 080 } 081 082 @Override 083 public int[] getDefaultTokens() { 084 return getRequiredTokens(); 085 } 086 087 @Override 088 public int[] getAcceptableTokens() { 089 return getRequiredTokens(); 090 } 091 092 @Override 093 public int[] getRequiredTokens() { 094 return new int[] {TokenTypes.METHOD_DEF}; 095 } 096 097 @Override 098 public void beginTree(DetailAST rootAST) { 099 objBlockWithEquals.clear(); 100 objBlockWithHashCode.clear(); 101 } 102 103 @Override 104 public void visitToken(DetailAST ast) { 105 if (isEqualsMethod(ast)) { 106 objBlockWithEquals.put(ast.getParent(), ast); 107 } 108 else if (isHashCodeMethod(ast)) { 109 objBlockWithHashCode.put(ast.getParent(), ast); 110 } 111 } 112 113 /** 114 * Determines if an AST is a valid Equals method implementation. 115 * 116 * @param ast the AST to check 117 * @return true if the {code ast} is an Equals method. 118 */ 119 private static boolean isEqualsMethod(DetailAST ast) { 120 final DetailAST modifiers = ast.getFirstChild(); 121 final DetailAST parameters = ast.findFirstToken(TokenTypes.PARAMETERS); 122 123 return CheckUtil.isEqualsMethod(ast) 124 && isObjectParam(parameters.getFirstChild()) 125 && (ast.findFirstToken(TokenTypes.SLIST) != null 126 || modifiers.findFirstToken(TokenTypes.LITERAL_NATIVE) != null); 127 } 128 129 /** 130 * Determines if an AST is a valid HashCode method implementation. 131 * 132 * @param ast the AST to check 133 * @return true if the {code ast} is a HashCode method. 134 */ 135 private static boolean isHashCodeMethod(DetailAST ast) { 136 final DetailAST modifiers = ast.getFirstChild(); 137 final DetailAST methodName = ast.findFirstToken(TokenTypes.IDENT); 138 final DetailAST parameters = ast.findFirstToken(TokenTypes.PARAMETERS); 139 140 return "hashCode".equals(methodName.getText()) 141 && parameters.getFirstChild() == null 142 && (ast.findFirstToken(TokenTypes.SLIST) != null 143 || modifiers.findFirstToken(TokenTypes.LITERAL_NATIVE) != null); 144 } 145 146 /** 147 * Determines if an AST is a formal param of type Object. 148 * 149 * @param paramNode the AST to check 150 * @return true if firstChild is a parameter of an Object type. 151 */ 152 private static boolean isObjectParam(DetailAST paramNode) { 153 final DetailAST typeNode = paramNode.findFirstToken(TokenTypes.TYPE); 154 final FullIdent fullIdent = FullIdent.createFullIdentBelow(typeNode); 155 final String name = fullIdent.getText(); 156 return "Object".equals(name) || "java.lang.Object".equals(name); 157 } 158 159 @Override 160 public void finishTree(DetailAST rootAST) { 161 objBlockWithEquals 162 .entrySet().stream().filter(detailASTDetailASTEntry -> { 163 return objBlockWithHashCode.remove(detailASTDetailASTEntry.getKey()) == null; 164 }).forEach(detailASTDetailASTEntry -> { 165 final DetailAST equalsAST = detailASTDetailASTEntry.getValue(); 166 log(equalsAST, MSG_KEY_HASHCODE); 167 }); 168 objBlockWithHashCode.forEach((key, equalsAST) -> log(equalsAST, MSG_KEY_EQUALS)); 169 } 170 171}