001///////////////////////////////////////////////////////////////////////////////////////////////
002// checkstyle: Checks Java source code and other text files for adherence to a set of rules.
003// Copyright (C) 2001-2026 the original author or authors.
004//
005// This library is free software; you can redistribute it and/or
006// modify it under the terms of the GNU Lesser General Public
007// License as published by the Free Software Foundation; either
008// version 2.1 of the License, or (at your option) any later version.
009//
010// This library is distributed in the hope that it will be useful,
011// but WITHOUT ANY WARRANTY; without even the implied warranty of
012// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
013// Lesser General Public License for more details.
014//
015// You should have received a copy of the GNU Lesser General Public
016// License along with this library; if not, write to the Free Software
017// Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
018///////////////////////////////////////////////////////////////////////////////////////////////
019
020package com.puppycrawl.tools.checkstyle.checks.imports;
021
022import java.util.HashSet;
023import java.util.Set;
024
025import com.puppycrawl.tools.checkstyle.FileStatefulCheck;
026import com.puppycrawl.tools.checkstyle.api.AbstractCheck;
027import com.puppycrawl.tools.checkstyle.api.DetailAST;
028import com.puppycrawl.tools.checkstyle.api.FullIdent;
029import com.puppycrawl.tools.checkstyle.api.TokenTypes;
030
031/**
032 * <div>
033 * Checks that there are no import statements that use the {@code *} notation.
034 * </div>
035 *
036 * <p>
037 * Rationale: Importing all classes from a package or static
038 * members from a class leads to tight coupling between packages
039 * or classes and might lead to problems when a new version of a
040 * library introduces name clashes.
041 * </p>
042 *
043 * <p>
044 * Notes:
045 * Note that property {@code excludes} is not recursive, subpackages of excluded
046 * packages are not automatically excluded.
047 * </p>
048 *
049 * @since 3.0
050 */
051@FileStatefulCheck
052public class AvoidStarImportCheck
053    extends AbstractCheck {
054
055    /**
056     * A key is pointing to the warning message text in "messages.properties"
057     * file.
058     */
059    public static final String MSG_KEY = "import.avoidStar";
060
061    /**
062     * A key is pointing to the warning message text in "messages.properties"
063     * file.
064     */
065    public static final String MSG_COUNT = "import.avoidStarCount";
066
067    /** Suffix for the star import. */
068    private static final String STAR_IMPORT_SUFFIX = ".*";
069
070    /**
071     * Specify packages where starred class imports are
072     * allowed and classes where starred static member imports are allowed.
073     */
074    private final Set<String> excludes = new HashSet<>();
075
076    /**
077     * Control whether to allow starred class imports like
078     * {@code import java.util.*;}.
079     */
080    private boolean allowClassImports;
081
082    /**
083     * Control whether to allow starred static member imports like
084     * {@code import static org.junit.Assert.*;}.
085     */
086    private boolean allowStaticMemberImports;
087
088    /**
089     * Maximum number of allowed star imports.
090     */
091    private int maxAllowedStarImports;
092
093    /**
094     * Counter for used star imports.
095     */
096    private int currentStarImportsCount;
097
098    @Override
099    public int[] getDefaultTokens() {
100        return getRequiredTokens();
101    }
102
103    @Override
104    public int[] getAcceptableTokens() {
105        return getRequiredTokens();
106    }
107
108    @Override
109    public int[] getRequiredTokens() {
110        // original implementation checks both IMPORT and STATIC_IMPORT tokens to avoid ".*" imports
111        // however user can allow using "import" or "import static"
112        // by configuring allowClassImports and allowStaticMemberImports
113        // To avoid potential confusion when user specifies conflicting options on configuration
114        // (see example below) we are adding both tokens to Required list
115        //   <module name="AvoidStarImport">
116        //      <property name="tokens" value="IMPORT"/>
117        //      <property name="allowStaticMemberImports" value="false"/>
118        //   </module>
119        return new int[] {TokenTypes.IMPORT, TokenTypes.STATIC_IMPORT};
120    }
121
122    /**
123     * Setter to specify packages where starred class imports are
124     * allowed and classes where starred static member imports are allowed.
125     *
126     * @param excludesParam package names/fully-qualifies class names
127     *     where star imports are ok
128     * @since 3.2
129     */
130    public void setExcludes(String... excludesParam) {
131        for (final String exclude : excludesParam) {
132            if (exclude.endsWith(STAR_IMPORT_SUFFIX)) {
133                excludes.add(exclude);
134            }
135            else {
136                excludes.add(exclude + STAR_IMPORT_SUFFIX);
137            }
138        }
139    }
140
141    /**
142     * Setter to control whether to allow starred class imports like
143     * {@code import java.util.*;}.
144     *
145     * @param allow true to allow false to disallow
146     * @since 5.3
147     */
148    public void setAllowClassImports(boolean allow) {
149        allowClassImports = allow;
150    }
151
152    /**
153     * Setter to control whether to allow starred static member imports like
154     * {@code import static org.junit.Assert.*;}.
155     *
156     * @param allow true to allow false to disallow
157     * @since 5.3
158     */
159    public void setAllowStaticMemberImports(boolean allow) {
160        allowStaticMemberImports = allow;
161    }
162
163    /**
164     * Setter to control how many star imports are allowed.
165     *
166     * @param count the number of star imports allowed
167     * @since 13.5.0
168     */
169    public void setMaxAllowedStarImports(int count) {
170        maxAllowedStarImports = count;
171    }
172
173    @Override
174    public void beginTree(DetailAST rootAST) {
175        currentStarImportsCount = 0;
176    }
177
178    @Override
179    public void visitToken(final DetailAST ast) {
180        if (ast.getType() == TokenTypes.IMPORT) {
181            if (!allowClassImports) {
182                final DetailAST startingDot = ast.getFirstChild();
183                logsStarredImportViolation(startingDot);
184            }
185        }
186        else if (!allowStaticMemberImports) {
187            // must navigate past the static keyword
188            final DetailAST startingDot = ast.getFirstChild().getNextSibling();
189            logsStarredImportViolation(startingDot);
190        }
191    }
192
193    /**
194     * Gets the full import identifier.  If the import is a starred import and
195     * it's not excluded then a violation is logged.
196     *
197     * @param startingDot the starting dot for the import statement
198     */
199    private void logsStarredImportViolation(DetailAST startingDot) {
200        final FullIdent name = FullIdent.createFullIdent(startingDot);
201        final String importText = name.getText();
202        final boolean isStarImport = importText.endsWith(STAR_IMPORT_SUFFIX);
203        if (isStarImport) {
204            currentStarImportsCount++;
205            if (currentStarImportsCount > maxAllowedStarImports
206                    && !excludes.contains(importText)) {
207                if (maxAllowedStarImports > 0) {
208                    log(startingDot, MSG_COUNT, maxAllowedStarImports);
209                }
210                else {
211                    log(startingDot, MSG_KEY, importText);
212                }
213            }
214        }
215    }
216}