001/////////////////////////////////////////////////////////////////////////////////////////////// 002// checkstyle: Checks Java source code and other text files for adherence to a set of rules. 003// Copyright (C) 2001-2026 the original author or authors. 004// 005// This library is free software; you can redistribute it and/or 006// modify it under the terms of the GNU Lesser General Public 007// License as published by the Free Software Foundation; either 008// version 2.1 of the License, or (at your option) any later version. 009// 010// This library is distributed in the hope that it will be useful, 011// but WITHOUT ANY WARRANTY; without even the implied warranty of 012// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU 013// Lesser General Public License for more details. 014// 015// You should have received a copy of the GNU Lesser General Public 016// License along with this library; if not, write to the Free Software 017// Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA 018/////////////////////////////////////////////////////////////////////////////////////////////// 019 020package com.puppycrawl.tools.checkstyle.checks.coding; 021 022import java.util.ArrayList; 023import java.util.List; 024import java.util.Optional; 025 026import com.puppycrawl.tools.checkstyle.StatelessCheck; 027import com.puppycrawl.tools.checkstyle.api.AbstractCheck; 028import com.puppycrawl.tools.checkstyle.api.DetailAST; 029import com.puppycrawl.tools.checkstyle.api.TokenTypes; 030 031/** 032 * <div> 033 * Checks that all constructors are grouped together. 034 * If there is any non-constructor code separating constructors, 035 * this check identifies and logs a violation for those ungrouped constructors. 036 * The violation message will specify the line number of the last grouped constructor. 037 * Comments between constructors are allowed. 038 * </div> 039 * 040 * <p> 041 * Rationale: Grouping constructors together in a class improves code readability 042 * and maintainability. It allows developers to easily understand 043 * the different ways an object can be instantiated 044 * and the tasks performed by each constructor. 045 * </p> 046 * 047 * @since 10.17.0 048 */ 049 050@StatelessCheck 051public class ConstructorsDeclarationGroupingCheck extends AbstractCheck { 052 053 /** 054 * A key is pointing to the warning message text in "messages.properties" 055 * file. 056 */ 057 public static final String MSG_KEY = "constructors.declaration.grouping"; 058 059 /** 060 * A key is pointing to the warning message text in "messages.properties" 061 * file. 062 */ 063 public static final String MSG_ORDER = "constructors.declaration.order"; 064 065 /** 066 * Control whether to order constructors by increasing parameter count or not. 067 */ 068 private boolean orderByIncreasingParameterCount; 069 070 /** 071 * Setter to control whether to enforce order by increasing parameter count (arity) or not. 072 * 073 * @param orderByIncreasingParameterCount true if order by increasing parameter 074 * count is required. 075 * @since 13.5.0 076 */ 077 public void setOrderByIncreasingParameterCount(boolean orderByIncreasingParameterCount) { 078 this.orderByIncreasingParameterCount = orderByIncreasingParameterCount; 079 } 080 081 @Override 082 public int[] getDefaultTokens() { 083 return getRequiredTokens(); 084 } 085 086 @Override 087 public int[] getAcceptableTokens() { 088 return getRequiredTokens(); 089 } 090 091 @Override 092 public int[] getRequiredTokens() { 093 return new int[] { 094 TokenTypes.CLASS_DEF, 095 TokenTypes.ENUM_DEF, 096 TokenTypes.RECORD_DEF, 097 }; 098 } 099 100 @Override 101 public void visitToken(DetailAST ast) { 102 // list of all child ASTs 103 final List<DetailAST> children = getChildList(ast); 104 105 // find first constructor 106 final DetailAST firstConstructor = children.stream() 107 .filter(ConstructorsDeclarationGroupingCheck::isConstructor) 108 .findFirst() 109 .orElse(null); 110 111 if (firstConstructor != null) { 112 113 // get all children AST after the first constructor 114 final List<DetailAST> childrenAfterFirstConstructor = 115 children.subList(children.indexOf(firstConstructor), children.size()); 116 117 // find the first index of non-constructor AST after the first constructor, if present 118 final Optional<Integer> indexOfFirstNonConstructor = childrenAfterFirstConstructor 119 .stream() 120 .filter(currAst -> !isConstructor(currAst)) 121 .findFirst() 122 .map(children::indexOf); 123 124 // list of all children after first non-constructor AST 125 final List<DetailAST> childrenAfterFirstNonConstructor = indexOfFirstNonConstructor 126 .map(index -> children.subList(index, children.size())) 127 .orElseGet(ArrayList::new); 128 129 // create a list of all constructors that are not grouped to log 130 final List<DetailAST> constructorsToLog = childrenAfterFirstNonConstructor.stream() 131 .filter(ConstructorsDeclarationGroupingCheck::isConstructor) 132 .toList(); 133 134 // find the last grouped constructor 135 final DetailAST lastGroupedConstructor = childrenAfterFirstConstructor.stream() 136 .takeWhile(ConstructorsDeclarationGroupingCheck::isConstructor) 137 .reduce((first, second) -> second) 138 .orElse(firstConstructor); 139 140 // log all constructors that are not grouped 141 constructorsToLog 142 .forEach(ctor -> log(ctor, MSG_KEY, lastGroupedConstructor.getLineNo())); 143 144 if (orderByIncreasingParameterCount) { 145 146 // list of all constructor ASTs 147 final List<DetailAST> allConstructors = children.stream() 148 .filter(ConstructorsDeclarationGroupingCheck::isConstructor) 149 .toList(); 150 151 int previousParamCount = 0; 152 boolean isOrdered = true; 153 for (DetailAST constructor : allConstructors) { 154 final int currentParamCount = getParameterCount(constructor); 155 isOrdered = isOrdered && currentParamCount >= previousParamCount; 156 previousParamCount = currentParamCount; 157 if (!isOrdered) { 158 log(constructor, MSG_ORDER); 159 } 160 } 161 } 162 } 163 } 164 165 /** 166 * Get a list of all children of the given AST. 167 * 168 * @param ast the AST to get children of 169 * @return a list of all children of the given AST 170 */ 171 private static List<DetailAST> getChildList(DetailAST ast) { 172 final List<DetailAST> children = new ArrayList<>(); 173 DetailAST child = ast.findFirstToken(TokenTypes.OBJBLOCK).getFirstChild(); 174 while (child != null) { 175 children.add(child); 176 child = child.getNextSibling(); 177 } 178 return children; 179 } 180 181 /** 182 * Check if the given AST is a constructor. 183 * 184 * @param ast the AST to check 185 * @return true if the given AST is a constructor, false otherwise 186 */ 187 private static boolean isConstructor(DetailAST ast) { 188 return ast.getType() == TokenTypes.CTOR_DEF 189 || ast.getType() == TokenTypes.COMPACT_CTOR_DEF; 190 } 191 192 /** 193 * Get the parameter count of a constructor. 194 * 195 * @param constructor the constructor AST 196 * @return the parameter count of the constructor 197 */ 198 private static int getParameterCount(DetailAST constructor) { 199 final DetailAST params = constructor.findFirstToken(TokenTypes.PARAMETERS); 200 int parameterCount = 0; 201 if (params != null) { 202 parameterCount = params.getChildCount(TokenTypes.PARAMETER_DEF); 203 } 204 return parameterCount; 205 } 206}